fix(lane-switch): block switching a lane when on main and there are staging components #6981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug found in the following scenario:
A component has a different scope than the lane. It was snapped on main, as a result, the
headprop of the Component model has changed locally. Later, the lane was switched to a local lane, runningbit exportthrew the following error:It happened because the remote-scope of the lane got the component object with a head that only exists locally.
It's not easy to fix this issue and it could happen only when switching from main to another lane. not from one lane to another. so for now, we just block it. Later, we might support it somehow.